check_openmanage 3.5.5-beta6 snmp_detect_blade bug

[Trond Hasle Amundsen]

"McKinlay, Ken" <Ken.McKinlay at curtisswright.com> writes:

> Trond,
>
> Other little bug for your next release. Using check_openmanage
> 3.5.5-beta6 on a server loaded with OMSA 5.1.0 (a different box this
> time), in the snmp_detect_blade function it returned: "INTERNAL ERROR:
> Use of uninitialized value in string eq at
> ./check_openmanage-3.5.5-beta6 line 599."
>
> Looking at the line and then doing my own SNMP query, that OID is
> missing in OMSA 5.1.0. However, by changing line 599 to first make sure
> a result has been set then the uninitialized value error is bypassed in
> the if statement:
>
> if ( $result->{$DellBaseBoardType} && $result->{$DellBaseBoardType} eq
> '3') {

Thank you, the patch is applied. Note that check_openmanage is not
designed to work with really old OMSA versions (5.2 and earlier). This
is more of a problem when checking locally, since omreport commands are
different. I generally won't add support for old OMSA if it has a
noticeable speed or complexity impact, but that is not the case here.
Besides, checking that the value exists is good practice anyway :)

An updated version is available here:

  http://folk.uio.no/trondham/tmp/check_openmanage-3.5.5-beta7

If you confirm that this beta works for you, and I don't get any more
bug reports in the next few days, this will eventually become 3.5.5.

Cheers,
-- 
Trond H. Amundsen <t.h.amundsen at usit.uio.no>
Center for Information Technology Services, University of Oslo

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Nagios-users mailing list
Nagios-users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-users
::: Please include Nagios version, plugin version (-v) and OS when reporting any issue. 
::: Messages without supporting info will risk being sent to /dev/null