[PATCH 1/1] trends-add-forward-to-next-problem.patch

[Andreas Ericsson]

On 01/07/2011 12:47 PM, Michael Friedrich wrote:
> Andreas Ericsson wrote:
>> On 01/07/2011 09:24 AM, Michael Friedrich wrote:
>>> Andreas Ericsson wrote:
>>>> On 01/03/2011 03:13 PM, Carsten Emde wrote:
>>>>
>>>> Applied and pushed. Thanks
>>>>
>>> Nice patch, thanks. It contains several inline declarations which i have
>>> reworked while applying against Icinga CGIs. Attached is a git patch against
>>> current Nagios HEAD (from git.op5.org, thx for the mirror) resolving those
>>> things too.
>> This patch is kinda backwards. It's considered best practice to have the
>> variables declared inside the outmost block they're used, so as to prevent
>> value spilling when the code is next modified.
> 
> It is?
> 

Yes. It allows the compiler to optimize the code better and prevents bugs
caused by reusing variables.

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl