[patch] Fix compiler warnings

Ethan Galstad egalstad at nagios.org
Mon Oct 4 04:33:09 CEST 2010


Michael Friedrich wrote:
[snip]
>>   	
>>   	if(data==NULL)
>> -		return;
>> +		return return_code;
> 
> I don't think this should be treated like this in regard of checking 
> data if NULL. Currently the return code not checked for OK|ERROR when 
> calling the function, but each call provides a void* typecasted svc or 
> hst for the data function param. In regard of continuous behavior I 
> would recommend changing that the way I proposed before - by returning 
> ERROR instead of OK, if data is NULL. see broker_host|service_check for 
> examples on returning return_code. It won't affect anything right now, 
> just keeping source clean.
> 
> Kind regards,
> Michael
> 

Agreed!  Changed in CVS.

-- 
Ethan Galstad
Father of Nagios
___
Email:  egalstad at nagios.org|com
Web:    www.nagios.com

------------------------------------------------------------------------------
Virtualization is moving to the mainstream and overtaking non-virtualized
environment for deploying applications. Does it make network security 
easier or more difficult to achieve? Read this whitepaper to separate the 
two and get a better understanding.
http://p.sf.net/sfu/hp-phase2-d2d




More information about the Developers mailing list