Nagios indentation

[Ethan Galstad]

On 11/19/2010 9:35 AM, eponymous alias wrote:
>> The nagios indentation has been discussed
>> quite a few times, and once upon a time we
>> agreed that it would be nifty if we could
>> use a style that's supported by a program
>> so contributors can auto-format their
>> code before submitting it upstream.
>
>> Unless someone complains before monday
>> I'll add a Makefile target to indent the sources,
>> run it once and then commit the results, with
>> a note added so that future contributors know
>> what to do to make their code conform to
>> the standard.
>
> While I agree on the objective of consistent
> formatting, I think the timing of this change
> is all wrong.  Patch contributors generally base
> their changes on the last stable release, which
> will remain with the old formatting.  Thus patches
> will need to be manually re-hacked for the new
> format if you make this change now.  Instead,
> wait until immediately before the next stable
> release, and make the change then, so everyone
> starts with the same code base for further patches.

Agreed.  This change should wait.

Code formatting should be fixed to be consistent with existing code 
*before* it is applied to CVS/SVN/etc.  Otherwise you get into a world 
of hurt un-applying patches if necessary.

There are several patches that have been applied with different styles 
lately.  These should be fixed to match the current coding/indentation 
style until a mass change is made on everything.

 From that point on, all patches should be in the same format as the 
main codebase, or should be made to match by committers before being 
applied.

- Ethan Galstad

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev