Question, and an Update for Command Expansion Patch (was: Bug and (loosely related) patch: Nagios 3.2.1 config.cgi, commands with $ARGs$)

[Jochen Bern]

On 08/31/2010 04:19 PM, Jochen Bern wrote:
> The whitespace detection is still not quite finished because I hit a
> snag in the existing code, namely, in cgi/cgiutils.c::url_encode() :

In the process of touching up 3.2.3 (CVS HEAD as of today) to include my
local patches, I had a look at the references to url_encode(); I don't
think that any reference *other* than the Command Expansion will ever
feed control characters into it. Thus, I fixed the "is a space"
comparison and removed the workaround in CE.

Also included in the attached patch:
-- corrected typo in "entry" hyperlink (thanks to Alexey Dvoryanchikov,
   via Icinga / Michael Friedrich)
-- added hyperlinks to the CE of (active) check commands and event
   handlers into the extinfo.cgi pages of hosts and services

-------

While I'm writing: I intend to streamline some more patches so that they
can be included into the authoritative source, but need to be activated
by explicit request. I'm thinking along the lines of
	CFLAGS="-DFEATURE_XY"
and optionally adding support into configure, pretty much like
	--with-feature-xy
Or is there an established other syntax/format/... to do this?

Kind regards,
								J. Bern
-- 
Jochen Bern, Systemingenieur --- LINworks GmbH <http://www.LINworks.de/>
Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt
PGP (1024D/4096g) FP = D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C27
Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202
Unternehmenssitz Weiterstadt, Geschäftsführer Metin Dogan, Oliver Michel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nagios-3.2.3-CommandExpandFixes-patch.txt
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20101105/9a09d6ff/attachment.txt>
-------------- next part --------------
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel