2 calls to unlink in checkresults

Andreas Ericsson ae at op5.se
Thu May 14 11:01:31 CEST 2009


Gerhard Lausser wrote:
> Hi,
> 
> i reported this bug in january 
> http://archive.netbsd.se/?ml=nagios-devel&a=2009-01&m=9671673
> http://archive.netbsd.se/?ml=nagios-devel&a=2009-01&m=9671670
> Imo, the condition for the second unlink needs to be reversed.
> 

Hmm. That would also be a bit off, imo. A better solution would
be to write the file directly to the check_result_path and then
just create the .ok file when checking is done. In that case, we
won't need to worry about cross-filesystem renames (which are
expensive since they always incur 4 disk-seeks and one memcopy).
Granted, the two of the seeks should always be cached, but it's
still 2 cold ones we can avoid entirely.

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Register now for Nordic Meet on Nagios, June 3-4 in Stockholm
 http://nordicmeetonnagios.op5.org/

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com




More information about the Developers mailing list