2 calls to unlink in checkresults

[Gerhard Lausser]

Hi,

i reported this bug in january 
http://archive.netbsd.se/?ml=nagios-devel&a=2009-01&m=9671673
http://archive.netbsd.se/?ml=nagios-devel&a=2009-01&m=9671670
Imo, the condition for the second unlink needs to be reversed.

Cheers,
Gerhard 

> -----Ursprüngliche Nachricht-----
> Von: Mathieu Gagné [mailto:mgagne at iweb.com] 
> Gesendet: Mittwoch, 13. Mai 2009 23:47
> An: Nagios Developers List
> Betreff: [Nagios-devel] 2 calls to unlink in checkresults
> 
> Hi,
> 
> I did a strace on the Nagios daemon and found out there's 2 
> calls to unlink for each check result file in checkresults.
> 
> For example:
> 
> stat64("/usr/local/nagios/var/spool/checkresults/cXKYnMY",
> {st_mode=S_IFREG|0600, st_size=475, ...}) = 0 
> stat64("/usr/local/nagios/var/spool/checkresults/cXKYnMY.ok",
> {st_mode=S_IFREG|0600, st_size=0, ...}) = 0
> time(NULL)                              = 1242249182
> open("/usr/local/nagios/var/spool/checkresults/cXKYnMY", 
> O_RDONLY) = 7 fstat64(7, {st_mode=S_IFREG|0600, st_size=475, 
> ...}) = 0 mmap2(NULL, 475, PROT_READ, MAP_PRIVATE, 7, 0) = 0xb7ee8000
> munmap(0xb7ee8000, 475)                 = 0
> close(7)                                = 0
> unlink("/usr/local/nagios/var/spool/checkresults/cXKYnMY") = 0
> unlink("/usr/local/nagios/var/spool/checkresults/cXKYnMY.ok") = 0
> 
> [......]
> 
> unlink("/usr/local/nagios/var/spool/checkresults/cXKYnMY") = 
> -1 ENOENT (No such file or directory)
> unlink("/usr/local/nagios/var/spool/checkresults/cXKYnMY.ok") 
> = -1 ENOENT (No such file or directory)
> 
> 
> Any idea about the source of this problem? (if it's one)
> 
> Here is the relevant configuration:
> temp_path=/usr/local/nagios/var/tmp
> check_result_path=/usr/local/nagios/var/spool/checkresults
> 
> Both folders are part of 2 different tmpfs filesystems:
> tmpfs   /usr/local/nagios/var/tmp tmpfs defaults,size=64m 0 0
> tmpfs   /usr/local/nagios/var/spool/checkresults tmpfs 
> defaults,size=32m 0 0
> 
> 
> --
> Mathieu
> 
> --------------------------------------------------------------
> ----------------
> The NEW KODAK i700 Series Scanners deliver under ANY 
> circumstances! Your production scanning environment may not 
> be a perfect world - but thanks to Kodak, there's a perfect 
> scanner to get the job done! With the NEW KODAK i700 Series 
> Scanner you'll get full speed at 300 dpi even with all image 
> processing features enabled. http://p.sf.net/sfu/kodak-com 
> _______________________________________________
> Nagios-devel mailing list
> Nagios-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nagios-devel
> 


------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com