host flapping update when actual check and wait time

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/03/09 03:17 AM, Hiren Patel wrote:
> Thomas Guyot-Sionnest wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 28/02/09 10:06 AM, Hiren Patel wrote:
>>> if there wasn't an actual check, and the wait time was below the
>>> required, an update should not be done. this is what is indicated by
>>> comments, but doesn't seem to be done in the implementation. please see
>>> if the attached diff is valid. thanks.
>>
>> After a quick look my understanding is that you should only change the
>> "<" sign to ">=".
>>
> 
> how so? the if condition checks for each situation as described by the
> comment, and if they're all true, sets update to false.
> that's my understanding of it, which makes sense to me based on what the
> comment is describing.

You're right, just realized the line below is only related to the
commented-out condition below it...

This part was modified to enable asynchronous, parallel and predictive
checks, and the return was later commented out as part of some
statistics bug fixes. Maybe it would be best to ask Ethan what he had in
mind... Or figure out a real issue that can be fixed.

- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJq+Pg6dZ+Kt5BchYRArbOAKD+ynwbGABz7/JEHgi4MwkoLtF3oACfXpTu
ep5uKOi+oDgzTQf43pyJVzY=
=Gqjz
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H