Comment IDs

Ricardo Maraschini ricardo.maraschini at opservices.com.br
Tue Jun 3 18:46:44 CEST 2008


Hi,

   I saw that Nagios version 3.0.x try to reuse the IDs from deleted comments to insert new ones. This is a little messing because in the CGIs the comments appears in an incorrect order(from the date point of view) allowing old comments to appears before newest(Specifically in migrations from 2.x to 3.x, or when a comment has been deleted).
   Maybe the correct form to solve this is adjusting CGI to order comments by date, I dont known. Anyway I did a change in xrddefault_read_state_information() to get the highest id when loading retention info(see attachment) and put this value in next_comment_id var. 
   With this logic store next_comment_id when saving retention data has become an unnecessary job(may be removed). 
   Can this solution impact in any other part of Nagios that actually I can't see?

   best regards.

-rm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 551 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20080603/d90c0257/attachment.bin>
-------------- next part --------------
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel


More information about the Developers mailing list