Patch submission for comments : CGI speed imp rovement (XNG)

[Fran=?utf-8?B?w6c=?=ois Laupretre]

Hi,

Thanks for your interest. I started to rewrite the code of this patch
because it is much too sensible to the way the compiler aligns its data
structures. I didn't try it on Linux but I tried it with several optimize
options (gcc) on Solaris and it proves that incrementing pointers in structs
is not reliable.

I started rewriting the code with two dedicated serialize & unserialize
functions for each data structure, but I didn't have enough time to complete
it, and I won't be available to work on it until the end of August.

Regards

François

> -----Original Message-----
> From: Andre Bergei [mailto:andre.bergei at ementor.no] 
> Sent: Wednesday, July 20, 2005 11:55 PM
> To: Laupretre, François (CALYON); nagios-devel at lists.sourceforge.net
> Subject: RE: [Nagios-devel] Patch submission for comments : 
> CGI speed improvement (XNG)
> 
> 
> >	Now, the next step is to see if you find it interesting 
> enough to 
> >include it in a future version of
> >nagios. If you test it, please let me know how much 
> improvement it brings in your case.
> >
> >	Installing :
> >
> >	The reference version for this patch is the 2.0b3 (I 
> will do it for 
> >the CVS version if needed). The file >names it uses are not 
> read in configuration file yet. They must be set manually in 
> xdata/xsdng.c and
> >xdata/xodng.c, as XSDNG_DUMP_FILE and XODNG_DUMP_FILE. In a 
> future version, the names can be derived from the 
> >'status_file' and 'object_cache_file' config vars, or there 
> can be two new config vars for them, TBD.
> >
> >	Regards
> >
> >	Fran篩s
> 
> Hi.
> 
> I decided to test this patch in my test enviroment against my 
> configuration with 3000 hosts and 30000 services, but after 
> patching nagios segfaults with
> 
> -snip
> Starting network monitor: nagios
> /etc/init.d/nagios: line 185:  4257 Segmentation fault      $NagiosBin
> -v $NagiosCfgFile >/dev/null 2>&1
> CONFIG ERROR!  Start aborted.  Check your Nagios configuration. -snip
> 
> Of course, my configuration works with clean nagios 2.0 code.
> 
> Here is my steps
> 
> I downloaded nagios2b3
> I patched it with: cat nagios_xng_patch_1.0 | patch -p1 
> ./configure prefix=/opt/nagios/ Make all (no errors) Make 
> install (no errors)
>  
> My system is a 2x3Ghz Xeon on Debian Sarge with GCC 3.3.5 
> Attached is a strace dump of the nagios execution.
> 
> 
> 
> cheers
> Andrè Bergei
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20050721/50e9cf18/attachment.html>
-------------- next part --------------
Ce message et ses pièces jointes (le "message") est destiné à l'usage    
exclusif de son destinataire.                                            
Si vous recevez ce message par erreur, merci d'en aviser immédiatement   
l'expéditeur  et de le détruire ensuite. Le présent message  pouvant  
être altéré à notre insu,  CALYON Corporate and Investment Bank                              
ne peut pas être engagé par son contenu. Tous droits réservés. 
          
This message and/or any  attachments (the "message") is intended for     
the sole use of its addressee.                                            
If you are not the addressee, please immediately notify the sender and    
then destroy the message.  As this message and/or any attachments may 
have been altered without our knowledge,  its content  is not legally 
binding on CALYON Corporate and Investment Bank. All rights reserved.