perfdata-file not working the same since upgrade from 3.0.2 to 3.3.1

[Michael Friedrich]

On 07.09.2011 11:26, Ton Voon wrote:
>
> On 7 Sep 2011, at 10:08, Michael Friedrich wrote:
>
>> On 2011-09-06 21:35, Joe Hoot wrote:
>>> Yep.  I had seen your post earlier and was hoping that there was an additional variable that I could add to tell nagios to include non-perfdata information in that file.  This is a shame.  In the past, my Nagios upgrades have went very smoothly.
>>>
>>> Thanks for the reply.   I am now happily up and running again on 3.2.3
>>
>> I've been tracking down this problem already in Icinga 1.3.x and
>> provided a proper fix for our users. Unless there's a properly tested
>> 3.3.x release you might wanna check my github branches for nagios 3.3.1
>> fixes. it's nothing official, but just a little help from the "other
>> evil side named Icinga" me being a core dev there too.
>>
>> https://github.com/dnsmichi/nagios-fixed/commits/3.3.1-fixes
>>
>> feel free to test and/or use that and provide feedback on the nagios
>> lists if any.
>
> Thanks for finding this Michael.
>
> I was going to change this so that enable_performance_processing=0 would not write anything, enable_performance_processing=1 does the old way (everything) and a new enable_performance_processing=2 would do this new behaviour.
>
> If you could amend your change to work in this way, I'll commit to core. If not, let me know and I'll look at it later.

sorry, been busy at work. i've now had a closer look into the code, the 
option you are actually referring to would be process_performance_data. 
changing this to a non boolean behaviour will require a lot of changes 
to the actual code (lots of conditions depending on either 0 or 1). So 
i'd vote either for a new config option (like i did in Icinga) or remove 
the code (as shown in my nagios-fixed tree).

kind regards,
michael

-- 
DI (FH) Michael Friedrich

Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria

email:     michael.friedrich at univie.ac.at
phone:     +43 1 4277 14359
mobile:    +43 664 60277 14359
fax:	   +43 1 4277 14338
web:       http://www.univie.ac.at/zid
            http://www.aco.net

Icinga Core&  IDOUtils Developer
http://www.icinga.org


------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
http://p.sf.net/sfu/rim-devcon-copy2
_______________________________________________
Nagios-users mailing list
Nagios-users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-users
::: Please include Nagios version, plugin version (-v) and OS when reporting any issue. 
::: Messages without supporting info will risk being sent to /dev/null