action_url issues

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 19/06/08 03:52 PM, Mathieu Gagné wrote:
> Hi,
> 
> Mathieu Gagné wrote:
>>
>> A bugfix has been applied in Nagios 3.0.2. In fact, the behavior in
>> Nagios 3.0.1 was the wrong one I guess.
>>
> 
> This bugfix was introduced here:
> http://thread.gmane.org/gmane.network.nagios.devel/5219/focus=5225
> 
> Some characters don't get encoded and the list is defined in
> ./common/macros.c on lin 2486
> 
> Those characters should not get encoded too: ":", "/", "?", "=" and "&".
> 
> Attached is a patch that fixes this urlencode issue.

Thanks. Indeed, I didn't fix it up myself because I did not have the
extra cycles to test and feared that it would have an unexpected
impact... I didn't expected the the url_encode function itself to be
broken though - I was rather thinking that it could apply other cleanup
options to places where it wasn't previously, exposing hidden bugs.

I should probably have expressed my fears in that email - unfortunately
it ended right on the 3.0.2 release...

Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIWyPw6dZ+Kt5BchYRAte7AKDTyXFCmtOHUl7Rrh43KSxGMTWtwgCfVw6G
VboHSl9QxUGW3vLSXzfeWnw=
=lfJ+
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Nagios-users mailing list
Nagios-users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-users
::: Please include Nagios version, plugin version (-v) and OS when reporting any issue. 
::: Messages without supporting info will risk being sent to /dev/null