<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML><HEAD> <META http-equiv=Content-Type content="text/html; charset=us-ascii"> <META content="MSHTML 6.00.6000.16981" name=GENERATOR></HEAD> <BODY style="WORD-WRAP: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space"> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>Hello, Ton.</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>Sorry for the delay, I've been quite busy lately.</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>I've looked through t-tap/* and </FONT></SPAN><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>found</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010></SPAN><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>no suitable test </FONT></SPAN><FONT face=Arial><FONT size=2><FONT color=#0000ff><SPAN class=789420513-29032010>which could be used</SPAN></FONT></FONT></FONT></DIV> <DIV dir=ltr align=left><FONT face=Arial><FONT size=2><FONT color=#0000ff><SPAN class=789420513-29032010>to test the described situation.</SPAN></FONT></FONT></FONT></DIV> <DIV dir=ltr align=left><FONT face=Arial><FONT size=2><FONT color=#0000ff><SPAN class=789420513-29032010><FONT></FONT></SPAN></FONT></FONT></FONT> </DIV> <DIV dir=ltr align=left><FONT face=Arial><FONT size=2><FONT color=#0000ff><SPAN class=789420513-29032010><FONT>Do you think this test </FONT></SPAN></FONT></FONT></FONT><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>should be new </FONT></SPAN><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>*.c file?</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>Do you expect full test </FONT></SPAN><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>(running event_execution_loop)</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>or just test for the function?</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>Since we're discussing the case do you think</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>it is possible to include the following patch</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>into main nagios (the same function):</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>--- checks.c.2 2010-03-05 15:54:53.000000000 +0300<BR>+++ checks.c 2010-03-29 17:16:03.000000000 +0400<BR>@@ -1583,17 +1583,25 @@<BR> /* if we're stalking this state type and state was not already logged AND the plugin output changed since last check, log it now.. */<BR> if(temp_service->state_type==HARD_STATE && state_change==FALSE && state_was_logged==FALSE && compare_strings(old_plugin_output,temp_service->plugin_output)){</FONT></SPAN></DIV> <DIV> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>- if((temp_service->current_state==STATE_OK && temp_service->stalk_on_ok==TRUE))<BR>+ if((temp_service->current_state==STATE_OK && temp_service->stalk_on_ok==TRUE)) {<BR> log_service_event(temp_service);<BR>+ handle_service_event(temp_service);<BR>+ }</FONT></SPAN></DIV> <DIV> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>- else if((temp_service->current_state==STATE_WARNING && temp_service->stalk_on_warning==TRUE))<BR>+ else if((temp_service->current_state==STATE_WARNING && temp_service->stalk_on_warning==TRUE)) {<BR> log_service_event(temp_service);<BR>+ handle_service_event(temp_service);<BR>+ }</FONT></SPAN></DIV> <DIV> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>- else if((temp_service->current_state==STATE_UNKNOWN && temp_service->stalk_on_unknown==TRUE))<BR>+ else if((temp_service->current_state==STATE_UNKNOWN && temp_service->stalk_on_unknown==TRUE)) {<BR> log_service_event(temp_service);<BR>+ handle_service_event(temp_service);<BR>+ }</FONT></SPAN></DIV> <DIV> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>- else if((temp_service->current_state==STATE_CRITICAL && temp_service->stalk_on_critical==TRUE))<BR>+ else if((temp_service->current_state==STATE_CRITICAL && temp_service->stalk_on_critical==TRUE)) {<BR> log_service_event(temp_service);<BR>+ handle_service_event(temp_service);<BR>+ }<BR> }</FONT></SPAN></DIV> <DIV> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2> #ifdef USE_EVENT_BROKER<BR></FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>Regards,</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2>Petya.</FONT></SPAN></DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV> <DIV dir=ltr align=left><SPAN class=789420513-29032010><FONT face=Arial color=#0000ff size=2></FONT></SPAN> </DIV><BR> <BLOCKQUOTE dir=ltr style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; MARGIN-RIGHT: 0px"> <DIV class=OutlookMessageHeader lang=ru dir=ltr align=left> <HR tabIndex=-1> <FONT face=Tahoma size=2><B>From:</B> Ton Voon [mailto:ton.voon@opsera.com] <BR><B>Sent:</B> Monday, March 08, 2010 4:13 PM<BR><B>To:</B> Nagios Developers List<BR><B>Subject:</B> Re: [Nagios-devel] broken SOFT/HARD transition logic<BR></FONT><BR></DIV> <DIV></DIV><BR> <DIV> <DIV>On 5 Mar 2010, at 13:42, Petya Kohts wrote:</DIV><BR class=Apple-interchange-newline> <BLOCKQUOTE type="cite"> <DIV>Sorry for spamming, previos ticket and patch were a mess,<BR>now the real problem with correct patch is here:<BR><BR><A href="http://tracker.nagios.org/view.php?id=130">http://tracker.nagios.org/view.php?id=130</A><BR></DIV></BLOCKQUOTE> <DIV><BR></DIV>Hi Petya,</DIV> <DIV><BR></DIV> <DIV>I've got this fixed already in the Opsview version of Nagios: <A href="https://secure.opsera.com/wsvn/wsvn/opsview/trunk/opsview-base/patches/nagios_host_failures_cause_incorrect_service_states.patch">https://secure.opsera.com/wsvn/wsvn/opsview/trunk/opsview-base/patches/nagios_host_failures_cause_incorrect_service_states.patch</A></DIV> <DIV><BR></DIV> <DIV>However, I haven't moved this back to core Nagios because I haven't got round to adding tests for it. Can you include a test in t-tap? (Use the CVS head or the snapshot at <A href="http://nagios.sourceforge.net/download/cvs/nagios-HEAD.tar.gz)">http://nagios.sourceforge.net/download/cvs/nagios-HEAD.tar.gz)</A></DIV> <DIV><BR></DIV> <DIV>Ton</DIV> <DIV><BR></DIV> <DIV><BR></DIV></BLOCKQUOTE></BODY></HTML>