<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi!<div><br></div><div>This patch was applied to Nagios Core and was in 3.2.0. I've fixed a specific problem last year with timeperiods when DST moved back one hour, but I didn't change the other occurrences of this patch. My feeling was to get a test case for the specific changes before reverting the patch.</div><div><br></div><div>However, I think there are still some timezone issues (as mentioned by Mark Frost on nagios-users), so I'm thinking that I should revert the entire patch and instead say that if you want to add the isdst=-1 in, then add test cases in.</div><div><br></div><div>Opinions?</div><div><br></div><div>Ton</div><div><br><div><div><div>On 30 Dec 2008, at 17:36, Albrecht Dreß wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi all:<br><br>please find attached to this message a diff against the current cvs which fixes a strange issue in Nagios 3.0.6 I discovered a while ago [1, 2]. Using it on my Ubuntu Hardy server since then, it seems to properly fix the issue. As always, any comment is welcome!<br><br>All the best for a happy, healthy and prosperous new year 2009,<br>Cheers,<br>Albrecht.<br><br>[1] <<a href="http://article.gmane.org/gmane.network.nagios.user/58359">http://article.gmane.org/gmane.network.nagios.user/58359</a>><br>[2] <<a href="http://article.gmane.org/gmane.network.nagios.user/58392">http://article.gmane.org/gmane.network.nagios.user/58392</a>><br><span><mktime-bug.diff></span>------------------------------------------------------------------------------<br>_______________________________________________<br>Nagios-devel mailing list<br><a href="mailto:Nagios-devel@lists.sourceforge.net">Nagios-devel@lists.sourceforge.net</a><br><a href="https://lists.sourceforge.net/lists/listinfo/nagios-devel">https://lists.sourceforge.net/lists/listinfo/nagios-devel</a><br></div></blockquote></div><br><div> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Calibri; font-size: 15px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><span class="Apple-style-span" style="font-family: Helvetica; font-size: 12px; "><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><span lang="EN-GB" style="font-size: 12pt; font-family: Arial, sans-serif; color: rgb(74, 11, 113); ">Ton Voon</span><span lang="EN-GB" style="font-size: 14pt; font-family: Arial, sans-serif; color: rgb(74, 11, 113); "><br></span><span style="font-size: 10pt; font-family: Arial, sans-serif; color: rgb(74, 11, 113); ">Product Architect</span><span lang="EN-GB" style="font-size: 12pt; font-family: 'Times New Roman', serif; "><o:p></o:p></span></div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><span style="font-family: 'Times New Roman', serif; "></span><br class="Apple-interchange-newline"><span></span><span><img height="33" width="100" src="cid:image001.gif@01C923BC.C9EBFE00"></span><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><span lang="EN-GB" style="font-size: 9pt; font-family: Arial, sans-serif; color: rgb(74, 11, 113); "><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">Opsera Limited | Unit 69 Suttons Business Park<br>Reading | Berkshire | RG6 1AZ | UK<b><br><br>Phone: </b>+44 (0) 845 057 7887<br><b>Mobile</b></span><b><span lang="EN-GB" style="font-size: 9pt; font-family: 'Times New Roman', serif; color: rgb(74, 11, 113); ">: </span></b><span lang="EN-GB" style="font-size: 9pt; font-family: Arial, sans-serif; color: rgb(74, 11, 113); ">+44 (0) 7931 365796<br><b>Skype</b>: tonvoon <b>Email:</b> <u><a href="mailto:ton.voon@opsera.com" style="color: blue; text-decoration: underline; ">ton.voon@opsera.com</a></u></span><b><span style="font-size: 10pt; font-family: Arial, sans-serif; "><br></span></b><span lang="EN-GB" style="font-size: 9pt; font-family: Arial, sans-serif; color: rgb(74, 11, 113); "><a href="http://www.opsera.com/" target="_blank" title="http://www.opsera.com" style="color: blue; text-decoration: underline; "><span style="color: rgb(74, 11, 113); ">www.opsera.com</span></a><o:p></o:p></span></div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><span style="font-size: 6pt; font-family: Arial, sans-serif; color: gray; ">This e-mail is confidential, intended only for the named recipient(s) above and may contain information that is privileged and confidential. If you receive this message in error, or are not the named recipient(s), please notify the sender at the phone number above, do not copy this message, do not disclose its contents to anyone, and delete this e-mail message from your computer. Although Opsera routinely screens for viruses, addressees should scan this e-mail and any attachments for viruses. Opsera makes no representation or warranty as to the absence of viruses in this e-mail or any attachments. Opsera Limited is registered in the UK under Company Number 5396532. Our registered office is Gorse View, Horsell Rise, Woking, Surrey, GU21 4RB.</span></div></span> </div></span></div></div></div></span></span></span></span></div><br></div></div></body></html>