[PATCH] Unused variables x and found_macro_x on process_macros_r()

Ricardo Maraschini ricardo.maraschini at opservices.com.br
Mon Jun 25 16:54:53 CEST 2012



----- Original Message -----
> On 06/22/2012 08:57 PM, Ricardo Maraschini wrote:
> > hello,
> > 
> > i've removed two unused variables on found_macro_x() function.
> > Compiler errors:
> > 
> > ../common/macros.c: In function ‘process_macros_r’:
> > ../common/macros.c:133:6: warning: variable ‘found_macro_x’ set but
> > not used [-Wunused-but-set-variable]
> > ../common/macros.c:128:6: warning: variable ‘x’ set but not used
> > [-Wunused-but-set-variable]
> > 
> > 
> > OK? Comments?
> > 
> 
> Test this with macro resolution debugging turned on. I just
> reverted a patch that did this change (and a bunch of other
> -Wunused-but-set-variable), and removing the unused ones
> actually broke macro resolution for the core.

Just for curiosity, the patch you've reverted had the same logic as mine regarding strcmp()?


-rm

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel


More information about the Developers mailing list