fix delete_all_host_comment, unschedule_downtime and delete_downtime_by_hostname_service_description_start_time_comment.

Dorian Guillois dguillois at merethis.com
Fri Oct 7 16:35:55 CEST 2011


On Thu, Oct 6, 2011 at 3:39 PM, Andreas Ericsson <ae at op5.se> wrote:
> On 10/06/2011 02:53 PM, Dorian Guillois wrote:
>> On Thu, Oct 6, 2011 at 2:37 PM, Andreas Ericsson<ae at op5.se>  wrote:
>>> On 10/06/2011 01:07 PM, Dorian Guillois wrote:
>>>> Hi everybody,
>>>>
>>>> Attached patches fix some bugs on functions delete_all_host_comment,
>>>> unschedule_downtime and
>>>> delete_downtime_by_hostname_service_description_start_time_comment. In
>>>> this 3 functions a pointer on a deleted object is used.
>>>>
>>>
>>> Good catch.
>>>
>>> There's a bug in your patches though. In all cases you point next_item to
>>> this_item->next, but then iterate it using next_item->next, meaning you'll
>>> skip every other item.
>>>
>>> If you resend corrected patches I'll apply them. Thanks
>>>
>>> --
>>> Andreas Ericsson                   andreas.ericsson at op5.se
>>> OP5 AB                             www.op5.se
>>> Tel: +46 8-230225                  Fax: +46 8-230231
>>>
>>> Considering the successes of the wars on alcohol, poverty, drugs and
>>> terror, I think we should give some serious thought to declaring war
>>> on peace.
>>>
>>
>> I'm so sorry. I was a little too fast.
>> delete_all_host_comment.patch was good, I resend the other file.
>>
>
> Applied. Thanks :)
>
> --
> Andreas Ericsson                   andreas.ericsson at op5.se
> OP5 AB                             www.op5.se
> Tel: +46 8-230225                  Fax: +46 8-230231
>
> Considering the successes of the wars on alcohol, poverty, drugs and
> terror, I think we should give some serious thought to declaring war
> on peace.
>

I found the same problem on the delete_host_acknowledgement_comments
function in comments.c.

Best regards,

-- 
Dorian GUILLOIS | Développeur

dguillois at merethis.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: delete_host_acknowledgement_comments.patch
Type: text/x-diff
Size: 961 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20111007/f47ff6e2/attachment.patch>
-------------- next part --------------
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel


More information about the Developers mailing list