[patch] Fix invalid DOM in CGI

Sven-Göran Bergh svengbergh-nagiosdevel at yahoo.com
Fri Dec 9 16:19:39 CET 2011


Sorry forgot to CC list.
>  Från: Andreas Ericsson <ae at op5.se>

>  Till: Sven-Göran Bergh <svengbergh-nagiosdevel at yahoo.com>; Nagios 
> Developers List <nagios-devel at lists.sourceforge.net>
>  Kopia: 
>  Skickat: fredag, 9 december 2011 15:47
>  Ämne: Re: [Nagios-devel] [patch] Fix invalid DOM in CGI
> 
>  On 12/09/2011 03:23 PM, Sven-Göran Bergh wrote:
>>   Attached patch fixes an invalid DOM.
>> 
>>   A table element may not have a form
>>   element as a direct child, but the
>>   opposite is OK.
>> 
>>   The forms become invalid in some browsers
>>   when the CGI:s are AJAX loaded in div
>>   element.
>> 
> 
>  Neat patch, but why not start the table directly after the form?
 
Because then some input element will end up directly inside the
table element, and that is not valid that either.
 
>  That way it would have been obvious that the patch doesn't change
>  the layout. Now it's split so I can't say for sure that it
>  doesn't without having to look at the code, and I won't have
>  time to do that until next week. Care to reroll and resend a
>  more easily reviewed patch?
 
I think the patch is correct as it is, so no :-)
 
>  Thanks.
 
Thanks
/S-G

------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/




More information about the Developers mailing list