Do not launch a shell for each check

[Matthieu Kermagoret]

On Tue, Jun 1, 2010 at 11:21 AM, Andreas Ericsson <ae at op5.se> wrote:
> On 05/31/2010 04:28 PM, Matthieu Kermagoret wrote:
>> I'd like to propose a performance patch for Nagios that reduces the
>> number of Nagios' descendant processes.
>>
>
> Thanks. The idea behind the patch is good. The patch itself is not so
> stellar though.
>

Thanks for your feedback. I rewrote it using Andreas' advice and Hiren
Patel's patch (who indeed already proposed a patch doing the same
thing here nine months ago :
http://article.gmane.org/gmane.network.nagios.devel/6971).

The patch I propose, handle simple commands with shell quoting (simple
and double quote). Every command containing any of these characters
(escaped or not) will be handled by the shell --> !$^&*()~[]|{};<>?`
<--

So any feedback on this new proposal ?

-- 
Matthieu KERMAGORET | Développeur

mkermagoret at merethis.com

MERETHIS est éditeur du logiciel Centreon.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nagios_no_popen_r2.patch
Type: text/x-patch
Size: 5937 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20100601/811da5b9/attachment.bin>
-------------- next part --------------
------------------------------------------------------------------------------

-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel