OT Re: Patch RFC - Nagios 3.2 - permanently remove sleep on run_event == FALSE in main loop (events.c) or conditionally remove using nagios.cfg configuration parameter?

Max perldork at webwizarddesign.com
Mon Nov 2 23:32:57 CET 2009


On Mon, Nov 2, 2009 at 5:13 PM, Hendrik Baecker <andurin at process-zero.de> wrote:
> Am 02.11.09 01:13, schrieb Max:
>> On Sun, Nov 1, 2009 at 6:49 PM, Christoph Maser <cmr at financial.com> wrote:
>>> Ok that sounds quite sane. Hm btw. why is line 1115 run_event=FALSE,
>>> isn't that set already?
>>
>> Yes, that is a bit of defensive programming I am sure by someone who
>> wasn't 100% comfortable with the source.  I do not know where the
>> Nagios core team came up with their syntax style, it is one i have
>> never seen anywhere else and I find it to be ugly.
>>
>
> 1st: *ouch* ;)

The product works wonderfully, and that was totally a subjective
comment :) and, actually, not meant to be on list, I hit reply all
instead of reply.  It is ok, I stand by my opinion and ..

It does not matter if I do not personally like the style :), when I
submit patches I make sure they conform to it, end of story, the
standard is what it is and I can work and live with it.  I am a total
Nagios fan and proponent of it.

> 2nd: AFAIR, there were some discussions in the past to pipe the code
> through intend... guess it's stale for the moment.
> http://wiki.nagios.org/index.php/Nagios_Core_Developer_Guidelines#Code_style
>
> So... the style has a name ;)

I will educate myself on it :).  it is fine I do not like it, it will
never keep me from using it, attempting to contribute to it :p, or
making sure that any code I submit matches the style.

- max

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference




More information about the Developers mailing list