broker call in disable_service_notifications

Ethan Galstad nagios at nagios.org
Wed Oct 15 16:59:50 CEST 2008


Good catch - patch will be in CVS shortly.

Marc DeTrano wrote:
> I believe I found a bug in commands.c, in : disable_service_notifications
> 
> (around line 3540 or so in HEAD).
> 
> The call to broker_adaptive_service_data comes before the switch to 
> svc->notifications_enabled=FALSE.
> 
> In enable_service_notifications, enable_host_notifications, and 
> disable_host_notifications, the switch always comes before the broker is 
> called.   This  means if you are trying to catch the disabling of 
> service notifications in a broker module (as I am doing), you have no 
> way to inspect the value of "notifications_enabled" to determine if this 
> was just enabled or disabled.
> 
> Hope this helps, and thanks for all the great work on Nagios.
> 
> Marc DeTrano
> Gridshield, S.A.
> 


- Ethan Galstad

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/




More information about the Developers mailing list