ndoutils with zlib

[Tilo Renz]

Hello list,

> Umm. Are you *monitoring* 1000 machines or are you using 1000 machines to do
> the monitoring? Just curious.. :)
We are monitoring some 1000 systems (POS-Systems in a german Drugstore)

> Besides that, why not use lzo instead? It's a lot faster (although it doesn't
> compress as well), and it comes with a minilzo.c that can easily be included
> into the sources for those platforms where the zlib header files aren't
> installed.
I did not knew about it, i will have a look at it.

> What did I do?
> 
> To make ndomod.c more readable, I refactored some of its
> functionality.
> 
> First, I moved the option-parsing to extra files parseopt.[c|h] 
> parseopt.h defines a struct to hold all configuration data for
> ndomod, replacing various global variables in ndomod.c. parseopt.c
> does the option-parsing with parameters given by nagios and the
> configuration file. It also contains the default values, formerly
> kept in ndomod.c.

This sounds like a worthy change in its own right, imo.
It should probably have been a patch of its own. I'll see what I
can make of it.

Fortunate, I have intermediate copies of my work. I will copy ndoutils with only this change this evening at http://joey.in-ulm.de/2008/ndoutils

> > I also [..]
> > I patched [..]
> > Finally [..]
> 
> I'll say it again: minilzo.c would have been a ton better for you :-/
> [..]
> Since this is intended to be a performance booster, I'd like to see
> some real numbers on what the performance was before and how this
> patch changes it. If it's major code-surgery for a 10% increase, I
> think it's safe to say it'll be dropped on the floor, but if it ups
> performance by several orders of magnitude, I'd be very interested
> to work on it. Either way, some real numbers, please.

I'll try to gather some numbers.

> I tried to build a .diff-file, but I doubt the attached file is
> really usefull. I published the whole changed ndoutils at
> http://joey.in-ulm.de/2008/ndoutils Please have a look at it.
> 
> It looks ok-ish, although far too large. I wish you'd have made
> several different patches of it so that each independant step
> could be reviewed and tested for correctness. As it stands now,
> it's two days worth of work to just review the entire patch,
> simply because the scope of the changes is so huge.

I agree, but we had to get it finished fast, because of christmas-shopping.

I'll diff and post the configuration-only refactored later this day.
Maybe this will be a good starting point for introducing minilzo.


Joey5337
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 3860 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20081210/d01300d6/attachment.bin>
-------------- next part --------------
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel