small bug in popen_timeout_alarm_handler() in popen.c

[Andreas Ericsson]

Jason Crawford wrote:
> There is a small bug in popen_timeout_alarm_handler() in popen.c where
> it assumes that the child_process variable actually exists, and I've
> had it be NULL when the signal got sent, and had check_ping at least
> core dump. It took me 2 days, but I found the bug and patched it
> enough so it doesn't segfault anymore if the signal is sent. If
> someone wants to go further into details about how I got this crash,
> email me (on list, I'm subscribed), as it doesn't always happen, but I
> think I found the situation where I can cause that signal to be sent
> while child_process is NULL. But since accessing a pointer when it can
> possibly be NULL is always bad, here's the patch that should go in
> anyways:
> 


Nice catch. However, the popen.c file hasn't been used for quite some 
time. Try a recent release and the problem is likely to go away (or 
better yet, use check_icmp which doesn't fork ping to run its check).

This is also the wrong list for nagiosplugin development. You'll have 
better luck at nagiosplug-devel at lists.sourceforge.net

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642