[PATCH] Fix to allow incomplete service dependency templates

[Ethan Galstad]

Gaspar, Carson wrote:
>> -----Original Message-----
>> From: nagios-devel-bounces at lists.sourceforge.net 
>> [mailto:nagios-devel-bounces at lists.sourceforge.net] On Behalf 
>> Of Ethan Galstad
>> Sent: Monday, December 11, 2006 3:05 PM
>> To: Nagios-Devel
>> Subject: Re: [Nagios-devel] [PATCH] Fix to allow incomplete 
>> service dependency templates
>>
>> Jason Hoos wrote:
>>> Since it's not a registered object, the servicedependency template 
>>> should be valid, but Nagios reports "Could not expand dependent 
>>> hostgroups and/or hosts specified in service dependency" instead.
>>>
>> Actually, I think this should result in an error message, even 
>> though the template dependency isn't going to be registered.  
>> Better to catch a problem earlier, rather than later when the 
>> template is being used.
> 
> I violently disagree. Templates are, by definition, semantically
> incomplete. Why is this config line any more or less vital than every
> other missing config line? By your logic, templates shouldn't exist at
> all.
> 

You are partially correct.  Templates are usually incomplete, but they 
should not contain incorrect data.  In your example the template 
references a hostgroup, which in turn has a bad membership list (one 
host does not exist).


Ethan Galstad,
Nagios Developer
---
Email: nagios at nagios.org
Website: http://www.nagios.org

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV